Default to system certificate store #682
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-rychlewski
force-pushed
the
system_cert_store
branch
from
8acc665 to
a92f562
Compare
|
My understanding is that most of them have their own certificates. For the few that don’t, being explicit maybe does not hurt? Thoughts? |
|
My experience in this area isn't too prolific, but in the few things I've used what you said is true. Where this PR came from is I had it on my todo list after a couple people said it would be useful in the google group: https://groups.google.com/g/elixir-ecto/c/31K2gjLVGRs. But I'm happy to keep things the way they are. Your call! |
|
Exactly. I think it is a sane default for the web but I am not sure if it works for databases. So let's skip it for now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this fit in with the recent changes to the
:ssloption? If the user provides ssl options but does not supply:cacertsor:cacertfilethen it uses the erlang default.